Remove deprecated functions and classes by DanielNoord · Pull Request #8409 · pylint-dev/pylint

DanielNoord · 2023-03-08T22:18:49Z

Type of Changes

	Type
✓	🔨 Refactoring
✓	📜 Docs

Description

We're getting there.

codecov · 2023-03-08T22:31:35Z

Codecov Report

Merging #8409 (3b4d040) into main (0db9441) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8409   +/-   ##
=======================================
  Coverage   95.68%   95.68%           
=======================================
  Files         176      175    -1     
  Lines       18504    18465   -39     
=======================================
- Hits        17705    17668   -37     
+ Misses        799      797    -2

Impacted Files	Coverage Δ
pylint/checkers/__init__.py	`93.93% <ø> (-0.18%)`	⬇️
pylint/checkers/utils.py	`96.00% <ø> (+0.15%)`	⬆️
pylint/lint/expand_modules.py	`95.18% <ø> (-0.23%)`	⬇️
pylint/lint/utils.py	`95.83% <ø> (-0.72%)`	⬇️
pylint/utils/__init__.py	`100.00% <ø> (ø)`
pylint/lint/__init__.py	`92.30% <100.00%> (ø)`
pylint/utils/utils.py	`86.78% <100.00%> (-0.23%)`	⬇️

Pierre-Sassoulas

We need to explain what's the alternative, for example "To make a checker reduce map data simply implement get_map_data and reduce_map_data." etc. etc. (We can copy paste from the deprecation message and adapt).

Pierre-Sassoulas · 2023-03-08T22:34:48Z

+A number of old utility functions and classes have been removed.
+These are ``MapReduceMixin``, ``is_inside_lambda``, ``check_messages``,
+``is_class_subscriptable_pep585_with_postponed_evaluation_enabled``,
+``get_python_paht``, ``fix_import_path`` and ``get_global_option``.


Suggested change

``get_python_paht``, ``fix_import_path`` and ``get_global_option``.

``get_python_path``, ``fix_import_path`` and ``get_global_option``.

DanielNoord · 2023-03-08T22:38:35Z

We need to explain what's the alternative, for example "To make a checker reduce map data simply implement get_map_data and reduce_map_data." etc. etc. (We can copy paste from the deprecation message and adapt).

I was wondering about that. It feels as if the changelog can become very long. Shouldn't we just refer to the code and let the old DeprecationWarnings show what needs to be changed?

Pierre-Sassoulas · 2023-03-08T22:42:32Z

Yeah it's going to be long but it's the place where people are going to look first when something break, so it needs to explain what to do imo (also if someone is taking care of the deprecation warnings they won't need it).

DanielNoord · 2023-03-09T10:30:05Z

@Pierre-Sassoulas LGTM!

DanielNoord · 2023-03-09T10:30:13Z

But docs fail :(

Pierre-Sassoulas

I don't think we can use enumeration in the fragments, because it's already inside an enumeration. It's probably fixable but also not worth imo.

github-actions · 2023-03-09T11:53:14Z

🤖 Effect of this PR on checked open source code: 🤖

Effect on django:
The following messages are now emitted:

Details

redefined-variable-type:
Redefinition of field type from django.db.models.fields.related.OneToOneField to django.forms.widgets.Widget
https://github.com/django/django/blob/32d4b61c313be5169137047e9fb3668da20a5d89/django/db/models/base.py#L346

Effect on music21:
The following messages are now emitted:

Details

invalid-name:
Attribute name "id" doesn't conform to '[a-z_][A-Za-z0-9_]{2,30}$' pattern
https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/base.py#L576
useless-suppression:
Useless suppression of 'attribute-defined-outside-init'
https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/base.py#L3193
useless-suppression:
Useless suppression of 'attribute-defined-outside-init'
https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/base.py#L3264
redefined-variable-type:
Redefinition of fundamental type from django.forms.widgets.Widget to music21.pitch.Pitch
https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/pitch.py#L3690
too-many-instance-attributes:
Too many instance attributes (33/20)
https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/roman.py#L1394
redefined-variable-type:
Redefinition of lastChord type from music21.chord.Chord to django.forms.widgets.Widget
https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/analysis/neoRiemannian.py#L435
redefined-variable-type:
Redefinition of n type from music21.note.Note to music21.note.GeneralNote
https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/abcFormat/translate.py#L354
redefined-variable-type:
Redefinition of sc3 type from music21.scale.MinorScale to music21.scale.MajorScale
https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/scale/test_scale_main.py#L163
useless-suppression:
Useless suppression of 'method-hidden'
https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/stream/base.py#L11551

The following messages are no longer emitted:

Details

invalid-name:
Attribute name "id" doesn't conform to '[a-z_][A-Za-z0-9_]{2,30}$' pattern
https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/prebase.py#L293
suppressed-message:
Suppressed 'attribute-defined-outside-init' (from line 3193)
https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/base.py#L3193
suppressed-message:
Suppressed 'attribute-defined-outside-init' (from line 3264)
https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/base.py#L3264
too-many-instance-attributes:
Too many instance attributes (34/20)
https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/roman.py#L1394
redefined-variable-type:
Redefinition of sc3 type from music21.scale.MajorScale to music21.scale.MinorScale
https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/scale/test_scale_main.py#L169
suppressed-message:
Suppressed 'method-hidden' (from line 11551)
https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/stream/base.py#L11552

Effect on pandas:
The following messages are now emitted:

Details

redefined-variable-type:
Redefinition of expected type from pandas.core.arrays.period.PeriodArray to pandas.core.indexes.base.Index
https://github.com/pandas-dev/pandas/blob/30992187146e923623bfc90f9dbb49c2c3cce5fb/pandas/_testing/__init__.py#L300

The following messages are no longer emitted:

Details

redefined-variable-type:
Redefinition of expected type from pandas.core.arrays.numpy_.PandasArray to pandas.core.indexes.base.Index
https://github.com/pandas-dev/pandas/blob/30992187146e923623bfc90f9dbb49c2c3cce5fb/pandas/_testing/__init__.py#L300

This comment was generated for commit 3b4d040

Changelog: https://pylint.pycqa.org/en/latest/whatsnew/3/3.0/index.html#summary-release-highlights remove `__implements__`: That attribute is apparently from a rejected PEP. They say to inherit from BaseChecker, which we are already doing. pylint-dev/pylint#8404 check_messages -> only_required_for_messages: Seems straightforward instructions. I haven't actually tested it. pylint-dev/pylint#8409 remove emptystring extension: Looks like this has been replaced by https://pylint.readthedocs.io/en/stable/user_guide/messages/convention/use-implicit-booleaness-not-comparison-to-string.html Which is disabled by default but we have `enable=ALL`, so I guess that means we indeed have it enabled. And update changelog URLs.

DanielNoord added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Mar 8, 2023

DanielNoord added this to the 3.0.0 milestone Mar 8, 2023

DanielNoord requested a review from Pierre-Sassoulas March 8, 2023 22:18

Pierre-Sassoulas requested changes Mar 8, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

Pierre-Sassoulas modified the milestones: 3.0.0, 3.0.0a6 Mar 9, 2023

This comment has been minimized.

Sign in to view

DanielNoord and others added 2 commits March 9, 2023 10:31

Remove deprecated functions and classes

374460e

Details of what to do in changelog

d7db439

Pierre-Sassoulas force-pushed the deprecate branch from b4e6e9d to d7db439 Compare March 9, 2023 09:38

Pierre-Sassoulas previously approved these changes Mar 9, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

Fix the fragment

3b4d040

Pierre-Sassoulas dismissed their stale review via 3b4d040 March 9, 2023 10:40

Pierre-Sassoulas approved these changes Mar 9, 2023

View reviewed changes

Pierre-Sassoulas merged commit b2ab82a into pylint-dev:main Mar 9, 2023

DanielNoord deleted the deprecate branch March 9, 2023 13:12

Pierre-Sassoulas mentioned this pull request Mar 31, 2023

Release branch 3.0.0a6 #8521

Merged

jacobtylerwalls mentioned this pull request Jun 10, 2023

Support duplicate-code message with --jobs #8757

Merged

Pierre-Sassoulas mentioned this pull request Oct 2, 2023

Release branch 3.0.0 #9093

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove deprecated functions and classes#8409

Remove deprecated functions and classes#8409
Pierre-Sassoulas merged 3 commits into
pylint-dev:mainfrom
DanielNoord:deprecate

DanielNoord commented Mar 8, 2023

Uh oh!

codecov Bot commented Mar 8, 2023 •

edited

Loading

Uh oh!

Pierre-Sassoulas left a comment

Uh oh!

Pierre-Sassoulas Mar 8, 2023

Uh oh!

DanielNoord commented Mar 8, 2023

Uh oh!

Pierre-Sassoulas commented Mar 8, 2023

Uh oh!

This comment has been minimized.

This comment has been minimized.

DanielNoord commented Mar 9, 2023

Uh oh!

DanielNoord commented Mar 9, 2023

Uh oh!

This comment has been minimized.

Pierre-Sassoulas left a comment

Uh oh!

github-actions Bot commented Mar 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	``get_python_paht``, ``fix_import_path`` and ``get_global_option``.
	``get_python_path``, ``fix_import_path`` and ``get_global_option``.

Uh oh!

Conversation

DanielNoord commented Mar 8, 2023

Type of Changes

Description

Uh oh!

codecov Bot commented Mar 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

Uh oh!

Pierre-Sassoulas Mar 8, 2023

Choose a reason for hiding this comment

Uh oh!

DanielNoord commented Mar 8, 2023

Uh oh!

Pierre-Sassoulas commented Mar 8, 2023

Uh oh!

This comment has been minimized.

This comment has been minimized.

DanielNoord commented Mar 9, 2023

Uh oh!

DanielNoord commented Mar 9, 2023

Uh oh!

This comment has been minimized.

Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Mar 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Mar 8, 2023 •

edited

Loading